SI-8447 fix TypeTree printing #3710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -715,7 +727,7 @@ trait ClassPrintTests { | |||
| |}""", | |||
| typedCode = sm""" | |||
| |object PM5 { | |||
| | scala.collection.immutable.List.apply(1, 2) match { | |||
| | scala.collection.immutable.List.apply[Int](1, 2) match { | |||
There was a problem hiding this comment.
Why's this printing an inferred type argument? I was under impression that wasEmpty handles this.
There was a problem hiding this comment.
Yes, it was surprise for me too. Here (wasEmpty || isEmpty) is false
There was a problem hiding this comment.
Its original is null (I hope so :)). I think wasEmpty is false (I can't check it right now, I'll see a bit later). Since (wasEmpty || isEmpty) is false, TypeTree is not empty, so its tpe is used for printing.
There was a problem hiding this comment.
Yes, wasEmpty is false
|
Can you please resubmit this against the 2.11.x branch, and finish the review process on the new PR? Thanks! |
|
Resubmitted pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TypeTree printing based on tpe to CodePrinter (if original is not available) - SI-8447