Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/8325 spec update #3722

Merged
merged 1 commit into from May 12, 2014
Merged

Conversation

som-snytt
Copy link
Contributor

Remove the clause in 3.2.8 that reserves * as a postfix
modifier thing. For emphasis, the language that an infix
type name can be an arbitrary identifier is retained, sans buts.

Remove the clause in 3.2.8 that reserves `*` as a postfix
modifier thing.  For emphasis, the language that an infix
type name can be an arbitrary identifier is retained, sans buts.
@adriaanm
Copy link
Contributor

adriaanm commented May 9, 2014

For our reference, fixed by #444 & #3576. It's a bit late to ask, but, for my info, where was this change discussed? The tickets around this (https://issues.scala-lang.org/browse/SI-8325, https://issues.scala-lang.org/browse/SI-5702) are a bit terse.

@retronym
Copy link
Member

retronym commented May 9, 2014

Perhaps I was hasty in merging #3576. I assumed this was a bug fix in the parser, rather than an inconsistency in the spec.

@adriaanm
Copy link
Contributor

adriaanm commented May 9, 2014

It's probably fine, but it does introduce more look/peek-ahead (the only other instance I saw was also for something starry).

@som-snytt
Copy link
Contributor Author

Sorry for the veneer of presumption.

The pattern case was motivated around https://issues.scala-lang.org/browse/SI-3189.

Back then, I didn't know star was prohibited by the spec. In retrospect, maybe regular expression syntax did make it prohibitive, but that's just a guess.

The current fix is for regularity with that change; at some point I noticed that it was specified.

It seemed easy to disambiguate. As usual, would be nice to have a test ensuring that performance was not affected.

@adriaanm
Copy link
Contributor

LGTM That it seemed more like a bug than a spec change says it all, I 'spose.

adriaanm added a commit that referenced this pull request May 12, 2014
@adriaanm adriaanm merged commit 984fe09 into scala:2.11.x May 12, 2014
@som-snytt
Copy link
Contributor Author

Seems? Nay, it is. I know not seems.

@som-snytt som-snytt deleted the issue/8325-spec-update branch May 27, 2014 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants