SI-8475 GroupedIterator is also lazy when padded #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the related case which dnlgtm in the previous fix. The old code seems to be tilting for laziness, but we have to fill the buffer with the current group anyway, so there is no reason to be coy about calling ArrayBuffer.length.
| if (shortBy > 0) res ++ padding(shortBy) else res | ||
| } | ||
| else res | ||
| // was: extra checks so we don't calculate length unless there's reason |
There was a problem hiding this comment.
Don't need to explain the history, just explain what we do now.
There was a problem hiding this comment.
It's a marker that the analysis of laziness is incomplete. (Todo is clarify the comment at 922, unlazy the vals at 956.) If I follow up with a minor refactor of takeDestructively, I will follow your advice and let the dead bury the dead.
|
LGTM, though I would shorten the comment so future maintainers are not unduly burdened with history. |
adriaanm
added a commit
that referenced
this pull request
Jun 3, 2014
SI-8475 GroupedIterator is also lazy when padded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the related case which dnlgtm in the previous fix.
The old code seems to be tilting for laziness, but we have
to fill the buffer with the current group anyway, so there
is no reason to be coy about calling ArrayBuffer.length.