SI-8719 pattern expander errors and warnings now go through context #3876
Conversation
This ensures that typechecking custom unapplications in silent mode doesn't leak uncatchable errors. Interestingly enough, the problem only manifested itself for custom unapply methods, not for synthetic ones generated for case classes.
|
review @adriaanm |
| @@ -460,7 +460,7 @@ abstract class UnCurry extends InfoTransform | |||
| case UnApply(fn, args) => | |||
| val fn1 = transform(fn) | |||
| val args1 = fn.symbol.name match { | |||
| case nme.unapplySeq => transformArgs(tree.pos, fn.symbol, args, patmat.alignPatterns(tree).expectedTypes) | |||
| case nme.unapplySeq => transformArgs(tree.pos, fn.symbol, args, patmat.alignPatterns(global.typer.context, tree).expectedTypes) | |||
There was a problem hiding this comment.
As far as I know, global.typer.context eq NoContext (which throws on error).
In any case, since you're after typer, context.issue will throw (and there is also no silent mode after typer). We should get rid of TypeError in my opinion, and just use reporter.error when you're not type checking. I assume the original distinction was that, after type checking, type errors indicate compiler bugs, so we should abort. Since that's not very user-friendly, most phases now catch that exception, log it (as reporter.error would've done) and then abort. This logic is also in the main phase loop (the phase is only advanced if !reporter.hasErrors).
There was a problem hiding this comment.
Are you suggesting to use the isPastTyper check in the error reporting portion of alignPatterns?
There was a problem hiding this comment.
I can't think of anything better right now. I'll include this in my PR. Looking at it now.
|
Thanks, could you please resubmit after the PR for adriaanm/scala@scala:2.11.x...report-filter-wip is merged (after 2.11.2)? |
|
See #3974 |
This ensures that typechecking custom unapplications in silent mode
doesn't leak uncatchable errors. Interestingly enough, the problem
only manifested itself for custom unapply methods, not for synthetic
ones generated for case classes.