Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-8786 disable part of thest that's failing the jdk8 build #3961

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Sep 3, 2014

As noted in SI-8786, this test currently fails the jdk 8 build.

@lrytz
Copy link
Member Author

lrytz commented Sep 3, 2014

review by @retronym

@scala-jenkins scala-jenkins added this to the 2.11.3 milestone Sep 3, 2014
@@ -11,6 +11,6 @@ public static void callSomeAnnotations() {
va.vi(1, 2, 3, 4);
varargz(5, 1.0, 2.0, 3.0);
va.vt(16, "", "", "");
System.out.println(va.vt1(16, "a", "b", "c"));
// System.out.println(va.vt1(16, "a", "b", "c"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a comment to link to the ticket

@retronym
Copy link
Member

retronym commented Sep 3, 2014

This reminded me of another problem with generic varargs: https://issues.scala-lang.org/browse/SI-1459?focusedCommentId=55693&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-55693

Not sure it there is any relationship between them, though.

@retronym
Copy link
Member

retronym commented Sep 3, 2014

s/thest/test

@retronym
Copy link
Member

retronym commented Sep 3, 2014

Indeed, bounding the generic type argument makes things work:

git diff
diff --git a/test/files/jvm/varargs/VaClass.scala b/test/files/jvm/varargs/VaClass.scala
index e94e8a6..83ce163 100644
--- a/test/files/jvm/varargs/VaClass.scala
+++ b/test/files/jvm/varargs/VaClass.scala
@@ -9,5 +9,5 @@ class VaClass {
   @varargs def vs(a: Int, b: String*) = println(a + b.length)
   @varargs def vi(a: Int, b: Int*) = println(a + b.sum)
   @varargs def vt[T](a: Int, b: T*) = println(a + b.length)
-  @varargs def vt1[T](a: Int, b: T*): T = b.head
+  @varargs def vt1[T <: String](a: Int, b: T*): T = b.head
 }

@lrytz
Copy link
Member Author

lrytz commented Sep 4, 2014

PTAL

@xeno-by
Copy link
Member

xeno-by commented Sep 4, 2014

@lrytz Both google and urban dictionary are failing me. What does this mean? :)

@lrytz
Copy link
Member Author

lrytz commented Sep 4, 2014

please take another look :-) http://www.urbandictionary.com/define.php?term=PTAL

@retronym
Copy link
Member

retronym commented Sep 4, 2014

LGTM

retronym added a commit that referenced this pull request Sep 4, 2014
SI-8786 disable part of thest that's failing the jdk8 build
@retronym retronym merged commit 9753f23 into scala:2.11.x Sep 4, 2014
@lrytz lrytz deleted the t8786-disable-test branch September 9, 2014 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants