-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-8786 disable part of thest that's failing the jdk8 build #3961
Conversation
review by @retronym |
@@ -11,6 +11,6 @@ public static void callSomeAnnotations() { | |||
va.vi(1, 2, 3, 4); | |||
varargz(5, 1.0, 2.0, 3.0); | |||
va.vt(16, "", "", ""); | |||
System.out.println(va.vt1(16, "a", "b", "c")); | |||
// System.out.println(va.vt1(16, "a", "b", "c")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do with a comment to link to the ticket
This reminded me of another problem with generic varargs: https://issues.scala-lang.org/browse/SI-1459?focusedCommentId=55693&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-55693 Not sure it there is any relationship between them, though. |
s/thest/test |
Indeed, bounding the generic type argument makes things work:
|
2301290
to
e9a6fbb
Compare
PTAL |
@lrytz Both google and urban dictionary are failing me. What does this mean? :) |
please take another look :-) http://www.urbandictionary.com/define.php?term=PTAL |
LGTM |
SI-8786 disable part of thest that's failing the jdk8 build
As noted in SI-8786, this test currently fails the jdk 8 build.