Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-8445, SI-6622 test cases, already fixed #4011

Merged
merged 1 commit into from Sep 30, 2014
Merged

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Sep 29, 2014

They were most likely fixed in #3931 / e310746.

The test case for SI-6622 is taken from Jason's PR #2654. I adjusted
the EnclosingMethod to be null in two places in the check file, for
the classes that are owned by fields (not methods).

They were most likely fixed in scala#3931 / e310746.

The test case for SI-6622 is taken from Jason's PR scala#2654. I adjusted
the EnclosingMethod to be `null` in two places in the check file, for
the classes that are owned by fields (not methods).
@lrytz
Copy link
Member Author

lrytz commented Sep 29, 2014

Review by @retronym

@scala-jenkins scala-jenkins added this to the 2.11.3 milestone Sep 29, 2014
@retronym
Copy link
Member

I'm sure we've discussed this, but what is the justification for have a null enclosing method, rather than using the constructor or the accessor?

@retronym
Copy link
Member

Oh, it is in line with the analogous Java code, so...

% cat sandbox/Test.java
class Test {
    public Object x = new Object() {};

    public static void main(String... args) {
        System.out.println(new Test().x.getClass().getEnclosingMethod());
    }
}

% javac -d /tmp sandbox/Test.java && java -classpath /tmp Test
null

LGTM

retronym added a commit that referenced this pull request Sep 30, 2014
SI-8445, SI-6622 test cases, already fixed
@retronym retronym merged commit a52db7f into scala:2.11.x Sep 30, 2014
@lrytz lrytz deleted the t8445-6622 branch September 30, 2014 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants