SI-7596 Curtail overloaded symbols during unpickling #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In code like:
object O { val x = A; def x(a: Any) = ... }
object P extends O.x.A
The unpickler was using an overloaded symbol for `x` in the
parent type of `P`. This led to compilation failures under
separate compilation.
The code that leads to this is in `Unpicklers`:
def fromName(name: Name) = name.toTermName match {
case nme.ROOT => loadingMirror.RootClass
case nme.ROOTPKG => loadingMirror.RootPackage
case _ => adjust(owner.info.decl(name))
}
This commit filters the overloaded symbol based its stability
unpickling a singleton type. That seemed a slightly safer place
than in `fromName`.
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 61949437) |
|
PLS REBUILD ALL I've taken three Jenkins nodes offline ( |
|
(kitty-note-to-self: ignore 61974454) |
|
LGTM This one must be coming from X-files unit. :) |
gkossakowski
added a commit
that referenced
this pull request
Nov 21, 2014
SI-7596 Curtail overloaded symbols during unpickling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code like:
The unpickler was using an overloaded symbol for
xin theparent type of
P. This led to compilation failures underseparate compilation.
The code that leads to this is in
Unpicklers:This commit filters the overloaded symbol based its stability
unpickling a singleton type. That seemed a slightly safer place
than in
fromName.Resubmission of #2664 incorporating review from @gkossakowski.
Review by @gkossakowski :)