SI-7521 Fix erasure of parametric value classes. #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Erasure.boxingErasure` exists to ensure that we use boxed primitives to represent the value, if the value class has type parameters referred to by its element type. However, this is implenented with a type map that runs deeply across the type. In the enclosed test case, we have `Repr=Array[Int]`, which should be erased to `Array[Int]`, _not_ to `Array[Integer]`. This commit ensures that the `boxingErasure` map only applies boxing at the top level, and not within array arguments. (Other type arguments will be erased, so we don't have to deal with them.)
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 62639043) |
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 62668375) |
|
LGTM |
gkossakowski
added a commit
that referenced
this pull request
Nov 21, 2014
SI-7521 Fix erasure of parametric value classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasure.boxingErasureexists to ensure that we use boxed primitivesto represent the value, if the value class has type parameters
referred to by its element type.
However, this is implenented with a type map that runs deeply
across the type. In the enclosed test case, we have
Repr=Array[Int], which should be erased toArray[Int], notto
Array[Integer].This commit ensures that the
boxingErasuremap only appliesboxing at the top level, and not within array arguments. (Other
type arguments will be erased, so we don't have to deal with them.)
Review by @gkossakowski