SI-7601 Scaladoc: img elements must have an "alt" attribute #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soc Would you mind if I take the ticket? @VladUreche Could you take a look? |
|
LGTM, thanks @kzys! |
| // FIXME: an entity *should* fall into one of the above categories, | ||
| // but AnyRef is somehow not | ||
| Image.Class | ||
| } |
There was a problem hiding this comment.
A purely style-related problem, but wouldn't it be easier to have:
def entityToImage(e: DocTemplateEntity) =
if (e.isTrait) Image.Trait
else if (e.isClass) Image.Class
else if (e.isAbstractType) Image.Type
else if (e.isAliasType) Image.Type
else if (e.isObject) Image.Object
else if (e.isPackage) Image.Package
else {
// FIXME: an entity *should* fall into one of the above categories,
// but AnyRef is somehow not
debuglog(s"No matching image for entity $e.")
Image.Class
}There was a problem hiding this comment.
Makes sense since we don't have a long expr inside if anymore. I won't add the debuglog since there is no debuglog here and referencing AnyRef is inevitable.
This change makes Scaladoc's HTML valid a bit.
|
@kzys No, go ahead! Thanks. |
VladUreche
pushed a commit
that referenced
this pull request
Mar 27, 2015
SI-7601 Scaladoc: img elements must have an "alt" attribute
|
Thanks @kzys! |
|
Should this be back-ported to 2.11.x? |
|
Let me take a look. It must be easy. |
|
Thanks! |
kzys
added a commit
to kzys/scala
that referenced
this pull request
Apr 3, 2015
This change makes Scaladoc's HTML valid a bit. Backport of scala#4407 to 2.11.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes Scaladoc's HTML valid a bit.