SI-6810 Disallow EOL in char literal #4590
Conversation
It's clear that char literals are one-lined like normal string literals. By the same token, pun intended, char literals accept unicode escapes the same as string literals, including `\u000A`. This commit adds the usual exclusions (CR, NL, SU). The spec is outdated in outlawing chars that are not "printable", in particular, the ASCII control codes. The original intention may have been that the ordinary string escapes are required, such as "\b\n". Note that some common escapes are absent, such as "\a".
Emphasize that literal parsing accepts Unicode escapes as if they were escaped. In particular, a newline represented by its Unicode escape does not terminate the line in the middle of a literal.
|
This LGTM, but as we're currently flying blind (community build not yet green) and very close to a wall (M2 needs to be out before I fire up the grill this weekend), I'm pushing to M3. The grapevine has chatter of M3 by end of August. |
|
NP complete as in no problemo. |
|
started a community build on this - also for me to get used to the new community build infra https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/73/parameters/ |
|
LGTM. the failures in the community build run are unrelated:
|
|
@adriaanm merge? |
|
I don't remember why this was worth a PR or what it was about, but I propose it as an easy merge b/c who cares. Cut down on the queue a bit. For future reference, I suggest the Scala team only accept PRs that make strings harder to use, because people shouldn't be using strings so much anyway. |
SI-6810 Disallow EOL in char literal
|
👍 |
It's clear that char literals are one-lined like normal
string literals.
By the same token, pun intended, char literals accept
unicode escapes the same as string literals, including
\u000A.This commit adds the usual exclusions (CR, NL, SU).
The spec is outdated in outlawing chars that are not
"printable", in particular, the ASCII control codes.
The original intention may have been that the ordinary
string escapes are required, such as "\b\n". Note that
some common escapes are absent, such as "\a".
Review by @adriaanm who wears specs