Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-9382 Privatize enhanced x in Tuple2Zipped.Ops #5191

Merged
merged 2 commits into from May 30, 2016

Conversation

som-snytt
Copy link
Contributor

Probably there should be an Abide rule to avoid leaking
the "underlying value" of a value class. The spec or SIP defines
"underlying type" but doesn't mention the underlying value.

The argument for concealing the member is that it is redundant
and makes autocompletion results harder to read. Also, possibly
an additional implicit might want to add a member so-named.

Probably there should be an Abide rule to avoid leaking
the "underlying value" of a value class. The spec or SIP defines
"underlying type" but doesn't mention the underlying value.

The argument for concealing the member is that it is redundant
and makes autocompletion results harder to read. Also, possibly
an additional implicit might want to add a member so-named.
@scala-jenkins scala-jenkins added this to the 2.12.0-M5 milestone May 25, 2016
@adriaanm
Copy link
Contributor

LGTM

@adriaanm adriaanm self-assigned this May 26, 2016
Consolated JUnit tests and heeded comment about private def and
code beauty.
@som-snytt
Copy link
Contributor Author

som-snytt commented May 26, 2016

@adriaanm Maybe you could sponsor me for a merit badge.

I noticed (xs, ys).zipped.unzip is non-trivial, so (xs, ys).zipped.colls is useful, even if the name is a bit casual.

Edit: alternatively, you could just get really annoyed.

@lrytz
Copy link
Member

lrytz commented May 30, 2016

the name is a bit casual

so is the type

scala> (List(1,2,3), List(4,5,6)).zipped.colls
res2: (scala.collection.TraversableLike[Int,List[Int]], scala.collection.IterableLike[Int,List[Int]]) = (List(1, 2, 3),List(4, 5, 6))

@lrytz lrytz merged commit 9edbe3d into scala:2.12.x May 30, 2016
@som-snytt som-snytt deleted the issue/9382 branch May 31, 2016 16:54
@adriaanm adriaanm added 2.12 and removed 2.12 labels Oct 29, 2016
@som-snytt som-snytt restored the issue/9382 branch June 26, 2020 20:49
@som-snytt som-snytt deleted the issue/9382 branch December 19, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants