Privatize the deprecated members of immutable.Range.
#5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @Ichoran. Also /cc @adriaanm regarding the 2.11/2.12 compatibility and the possibility of removing deprecated members. See also the mailing list discussion https://groups.google.com/forum/#!topic/scala-internals/OTfJuM747c0 |
|
Hum ... JVM segaults in one run test in each commit (not the same both times). |
|
/rebuild |
|
LGTM |
|
conflit de liaison à cause de #5076.. |
The implementation of these obscure members of `Range` are uselessly complicated for the purposes of `Range` itself. Making them private will allow to relax their semantics to the specific needs of `Range`, making them simpler, together with the initialization code of `Range`. `terminalElement` becomes dead code and is removed.
`lastElement` is only used in code paths where the range is non-empty. It is therefore wasteful to try and give it a sort of sensible value for empty ranges.
sjrd
force-pushed
the
privatize-range-members
branch
from
ef3a249
to
ec1e804
Compare
|
Rebased. |
|
/rebuild -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of these obscure members of
Rangeare uselessly complicated for the purposes ofRangeitself. Making them private will allow to relax their semantics to the specific needs ofRange, making them simpler, together with the initialization code ofRange.terminalElementbecomes dead code and is removed.Subsequently, we relax the initialization of
lastElementnot to care about the empty case, since it is only used in code paths where the range is non-empty.About compatibility with 2.11: this is not the first breaking change of deprecated parts of
Rangein 2.12.Rangewas sealed in cb1a452, according to a deprecated inheritance that was added in 2.11. The present PR is arguably a less damaging break than that.