SAM for subtypes of FunctionN #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RC1 target is tentative, we could postpone if this runs into trouble |
|
Test suite passing! Let's see what the community build says, and if ✅ , I say let's do it. |
|
https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/500/consoleFull (404 for now, other runs are ahead in queue) |
|
✅ ❗ |
|
maybe also add a regression test? |
|
Yes, once this has a test, I say let's merge. |
only exclude FunctionN types themselves from SAM, don't exclude their subtypes; we want e.g. trait T extends Function1[String, String] (x => x) : T to compile reference: scala/scala-dev#206
SethTisue
force-pushed
the
topic/sd-206
branch
from
ac1277f
to
d275b03
Compare
|
@lrytz look good? |
|
LGTM, yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only exclude FunctionN types themselves from SAM, don't exclude their
subtypes; we want e.g.
to compile
reference: scala/scala-dev#206