Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-9913 Lead span iterator finishes at state -1 #5378

Merged
merged 2 commits into from Oct 26, 2016

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Sep 6, 2016

Even if no elements fail the predicate (so that the trailing
iterator is empty).

Review by @Ichoran

JIRA: https://issues.scala-lang.org/browse/SI-9913

Even if no elements fail the predicate (so that the trailing
iterator is empty).
@scala-jenkins scala-jenkins added this to the 2.11.9 milestone Sep 6, 2016
@som-snytt
Copy link
Contributor Author

I noticed leading.status goes toward negative, while trailing.status goes toward positive.

It would be handy if one could introduce a private trait of constant value defs (inlined constants) and then for the compiler not to emit the trait class. I would name the constants if it were free. Or if it didn't emit the field at least for private[this] final val K = 42.

Extra privacy, and the tricky state transition is made
more tabular.
@adriaanm adriaanm assigned szeiger and Ichoran and unassigned Ichoran Oct 18, 2016
@szeiger
Copy link
Member

szeiger commented Oct 26, 2016

LGTM

@SethTisue SethTisue merged commit b9a16c4 into scala:2.11.x Oct 26, 2016
@SethTisue
Copy link
Member

thanks Som!

@som-snytt som-snytt deleted the issue/9913 branch October 26, 2016 16:19
@Ichoran
Copy link
Contributor

Ichoran commented Oct 26, 2016

@som @adriaanm - Sorry, still swamped. This one slipped through the cracks. I am not sure how you get cracks in a swamp, but there you go.

@SethTisue SethTisue modified the milestones: 2.11.11, 2.11.9 May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants