Whitelist the remaining changes since 2.12.0 that break all builds #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes were made in scala#5481, subsequently breaking binary compatibility checks after scala#5532 was merged, too. The affected methods are part of an internal implementation class. Whitelisting should be safe.
Merged
|
I put them in #5546 but FSR after two shots put them in both listings. |
|
LGTM |
|
Merging to make our builds succeed again, just in case #5546 will take a bit longer before it gets merged. @som-snytt The "generated filters" output of MiMa also tripped me up. Our forwards check is done by running a backwards check with swapped versions, so the filters will always be listed for "backwards" even when they really need to be used for "forwards". When I wrote that code MiMa didn't have a forwards mode yet. |
|
@szeiger Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes were made in #5481,
subsequently breaking binary compatibility checks after
#5532 was merged, too. The affected
methods are part of an internal implementation class. Whitelisting
should be safe.