upgrade MiMa to 0.1.12 #5571
Merged
upgrade MiMa to 0.1.12 #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
force-pushed
the
mima-upgrade
branch
from
04ee5fc
to
f31b5cf
Compare
|
@szeiger could you take this over and make sure the whitelist changes are sensible and don't indicate new bugs in MiMa (besides lightbend-labs/mima#147)? I'm in a rush so I just treated this as a mechanical task of getting |
26 tasks
|
See: lightbend-labs/mima#147, "False positives for classes defined inside methods" |
|
/rebuild |
1 similar comment
|
/rebuild |
szeiger
approved these changes
Dec 1, 2016
| matchName="scala.collection.Iterator#Leading#1.this" | ||
| problemName=DirectMissingMethodProblem | ||
| }, | ||
| // ??? not sure what this is about |
There was a problem hiding this comment.
Another instance of lightbend-labs/mima#147, fixed in MiMa master.
dogfooding the latest. upgrading all the way from 0.1.8 -- there have been a bunch of improvements since then.
SethTisue
force-pushed
the
mima-upgrade
branch
from
f31b5cf
to
6e35e2d
Compare
|
/nothingtoseehere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dogfooding the latest. upgrading all the way from 0.1.8 -- there have
been a bunch of improvements since then.