Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override equals and hashCode for WrappedArray #5607

Merged
merged 1 commit into from Dec 21, 2016

Conversation

adriaanm
Copy link
Contributor

Rebase of #5551 (also removed mima filter that should no longer be needed)

@scala-jenkins scala-jenkins added this to the 2.12.2 milestone Dec 20, 2016
@adriaanm adriaanm changed the title Override equals and hashCode for WrappedArray [Rebase of #5551] Override equals and hashCode for WrappedArray Dec 20, 2016
@lrytz
Copy link
Member

lrytz commented Dec 21, 2016

The whitelist change moved from bincompat-forward.whitelist.conf to bincompat-backward.whitelist.conf, which seems to be wrong

@lrytz
Copy link
Member

lrytz commented Dec 21, 2016

I git push -f'd to your branch, how evil! 🙈

@adriaanm
Copy link
Contributor Author

🙉

@adriaanm adriaanm changed the title [Rebase of #5551] Override equals and hashCode for WrappedArray Override equals and hashCode for WrappedArray Dec 21, 2016
@adriaanm adriaanm merged commit bf9b00e into scala:2.12.x Dec 21, 2016
@adriaanm adriaanm deleted the rebase-5551 branch December 21, 2016 21:12
@alexeyr
Copy link
Contributor

alexeyr commented Dec 22, 2016

@lrytz It seemed wrong to me to, but that's what I had to do to avoid MiMa errors. Maybe MiMa had a bug fixed since then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants