Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala-xml dependency should be provided #5689

Closed
wants to merge 3 commits into from
Closed

scala-xml dependency should be provided #5689

wants to merge 3 commits into from

Commits on Feb 13, 2017

  1. scala-xml dependency should be provided 

    Nothing should transitively depend on the scala-xml module except for
scaladoc and library-all.

Compiler needs scala-xml as a build dependency, but not at runtime.

The user is supposed to provide scala-xml as a dependency at runtime.
This fixes an issue where the classpath in SBT shadows the scala-xml
module, see scala/scala-module-dependency-sample#14.

Unfortunately, scaladoc needs to be pulled out of the compiler.  This
is a first attempt at mangling the build so that scaladoc is a
separate jar.  Following on, SBT will need to know how to run scaladoc
as a separate jar.
    @ashawley
    ashawley committed Feb 13, 2017
    Copy the full SHA
    034ccfd View commit details
    Browse the repository at this point in the history

  2. Remove OSGi import header for scala.xml from compiler jar

    @ashawley
    ashawley committed Feb 13, 2017
    Copy the full SHA
    a818cce View commit details
    Browse the repository at this point in the history

  3. Note dependency on scala-xml by scaladoc is correct

    @ashawley
    ashawley committed Feb 13, 2017
    Copy the full SHA
    c9a2e5e View commit details
    Browse the repository at this point in the history