New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 2.10.7 #6128

merged 5 commits into from Oct 13, 2017


None yet
5 participants

adriaanm commented Oct 12, 2017

Since we're doing 2.10.7 for sbt on jdk 9, may as well backport these recent cleanups now that they're fresh in mind.

adriaanm and others added some commits Oct 12, 2017

Use https in pull-binary-libs
Mysterious failures in the http:// urls.
Add option -port to fsc
Option "port" limits compile server lookup and start to given port.
Normally fsc will start a compile server in a random port if no server
is yet running. This can be problematic with firewalls and/or remote
compile servers. Option "port" should not be confused with option
"server" which looks for a compile server in given host and port and
fails if such server is not found.

Automatic tests for command line user interface do not exist at all.
Thus, adding a test for one new option would require designing a whole
new testing method.

Cherry picked from 7daecd8
Move compilation daemon portfile under `~/.scalac/`
Store the compilation daemon's administrativia (port file, redirection)
under `~/.scalac/`, instead of the less standard

On creation, remove group- and other-permissions from these
private files, ditto for the repl's history file.

On Java 6 on Windows, opt in to compilation daemon using `-nc:false`.

Cherry picked from b64ad85, aa133c9, 2ceb09c

@adriaanm adriaanm requested a review from lrytz Oct 12, 2017

@adriaanm adriaanm added this to the 2.10.7 milestone Oct 12, 2017


lrytz approved these changes Oct 13, 2017

@adriaanm adriaanm merged commit 0f624c5 into scala:2.10.x Oct 13, 2017

4 checks passed

scala-2.11.x-integrate-ide [2840] SUCCESS. Took 11 s.
scala-2.11.x-validate-main [3155] SUCCESS. Took 57 min.
scala-2.11.x-validate-publish-core [3258] SUCCESS. Took 14 min.
scala-2.11.x-validate-test [2308] SUCCESS. Took 39 min.

raboof added a commit to raboof/sbt-api-mappings that referenced this pull request Oct 23, 2017

Build with scala 2.10.7
Which should have some jdk9 fixes (scala/scala#6128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment