Fixup symbol ownership in eta expansion #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Nov 24, 2017
| tree.changeOwner(typer.context.owner -> valSym) | ||
| } | ||
| valSym.setInfo(rhs.tpe) | ||
| ValDef(valSym, rhs) |
There was a problem hiding this comment.
looks good; def etaExpand could now take a owner: Symbol parameter instead of the full typer: Typer.
There was a problem hiding this comment.
Pushed a commit with that refactoring.
adriaanm
force-pushed
the
topic/eta-owner
branch
from
69273ab
to
a9d412f
Compare
adriaanm
approved these changes
Aug 3, 2018
| tree.changeOwner(typer.context.owner -> valSym) | ||
| } | ||
| valSym.setInfo(rhs.tpe) | ||
| ValDef(valSym, rhs) |
There was a problem hiding this comment.
Pushed a commit with that refactoring.
The fix for scala/bug#6274 did this selectively when function symbols were introduced, but we really ought to insert the eta$n temp vals into the owner chain of all lifted expressions.
Based on review by lrytz
adriaanm
force-pushed
the
topic/eta-owner
branch
from
a9d412f
to
05555e8
Compare
|
assuming not critical for M5. retarget if you disagree |
|
I think this one is ready to go, actually. If the resetAttrs interaction proves problematic, we can refine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for scala/bug#6274 did this selectively when function symbols
were introduced, but we really ought to insert the eta$n temp vals into
the owner chain of all lifted expressions.