remove Ant support, remove Eclipse support #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
force-pushed
the
no-ant-no-eclipse
branch
from
e084bb6
to
e9b1730
Compare
|
I have a sinking feeling somebody is going to come up with a reason the Ant stuff can't or shouldn't be removed? |
|
this would fix scala/bug#10335, but that's gravy, the main motivation here is just general cruft reduction. |
|
SethTisue
force-pushed
the
no-ant-no-eclipse
branch
from
e9b1730
to
2408bf5
Compare
SethTisue
force-pushed
the
no-ant-no-eclipse
branch
3 times, most recently
from
648f6ae
to
0506b4f
Compare
|
this is now ready for review. @lrytz want to take the first look? |
lrytz
approved these changes
Mar 1, 2018
|
I googled a bit to see if there's anything recent on scala+ant, this post is from July 2017, but seems to be taken from his 2013 book. Also stackoverflow for scala+ant seems to be calm. So 👍 from me. |
Merged
lrytz
force-pushed
the
no-ant-no-eclipse
branch
2 times, most recently
from
4bd61b4
to
53b5dad
Compare
|
@SethTisue rebased to fix conflict with #6354 and pushed to your branch |
|
@adriaanm wdyt? |
SethTisue
force-pushed
the
no-ant-no-eclipse
branch
from
53b5dad
to
7fb621b
Compare
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
Apr 25, 2018
Now that scala/scala#6255 is merged
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
Apr 25, 2018
Now that scala/scala#6255 is merged
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
Apr 25, 2018
Now that scala/scala#6255 is merged
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Now that scala/scala#6255 is merged
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Now that scala/scala#6255 is merged
lrytz
added a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
Now that scala#6255 is merged
lrytz
added a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
Now that scala#6255 is merged
|
discussion thread at https://users.scala-lang.org/t/scala-2-13-0-ant-support/4694/7 |
|
the removed code is now here: https://github.com/cigaly/scala-ant, thanks to @cigaly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove Ant tasks for building user code using Ant. this is
now historical. hard to be sure absolutely nobody is using it anymore,
but regardless, it ought to be a separate project, if anyone still
wants it to exist in 2.13+ world.
support for building Scala itself using Eclipse is removed and
replaced with a note in the readme that says "Support for Eclipse has
decayed and been removed, but could be resurrected by a volunteer"