Deeply focus the qualifier before using it as the RHS of the stabilizing val. #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing val. ...because rangepos expects offset-positioned trees not to contain range-positioned trees. This is the same approach that default arguments use when moving the RHS of the parameter val into a default getter. Alternatives: - Remove that assertion: I'm not sure what it's for, but the validation seems quite insistent on that point. I suspect that the IDE or PC or something using positions may break on that. - Use the tree duplicator (and don't make a focuser traverser). This is how the default args are currently done, but since we're not reusing `qual` here that I can see it doesn't seem too useful to waste the allocations that it would take to duplicate that tree. The test cases are just slapping `-Yrangepos` on all of the test cases introduced in bcbe993 (where this feature was introduced). `test/files/pos/t4225.scala` is not thus enhanced, since there's a similar rangeposly error with by-name arguments of right-associative methods. Fixes scala/bug#10706.
|
/sync (this didn't report back on a successful build immediately, but /sync seemed to work) |
lrytz
approved these changes
Feb 28, 2018
|
Thank you! |
|
Filed scala/bug#10751 for the right-associative by-name combo. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because rangepos expects offset-positioned trees not to contain range-positioned trees. This is the same approach that default arguments use when moving the RHS of the parameter val into a default getter.
Alternatives:
qualhere that I can see it doesn't seem too useful to waste the allocations that it would take to duplicate that tree.The test cases are just slapping
-Yrangeposon all of the test cases introduced in bcbe993 (where this feature was introduced).test/files/pos/t4225.scalais not thus enhanced, since there's a similar rangeposly error with by-name arguments of right-associative methods.Fixes scala/bug#10706, references scala/scala-dev#472.