New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade scala-xml to 1.1.0 #6341
Conversation
the hope of course is to get scala-xml out of the 2.13 bootstrap, but I'm not sure we'll get to it before M4. in the meantime, let's dogfood the new release.
This seems to break the boostrap build, at least the one used in the benchmarks. For example, in build bootstrap-benchmark/637/, the build log shows the failure due to the addition of ScalaJS to the scala-xml build.
|
@sjrd I remember you experimenting with a way to easily enable/disable the ScalaJS SBT plugin. Did that turn into something we can use? |
If you're talking about https://github.com/sjrd/sbt-dynscalajs, it works, yes. But please mind the readme about the expected level of support. Anyway, I don't think your problem here is that it can't load the plugin. The resolution errors you see only happen if you actually try to |
If you want to execute just the JVM targets in the scala-xml build, you can use the Why did this come up with upgrading the build to 1.1.0? The Scala.js changes have been in master for a year or so, now. |
Our bootstrap build was rebuilding the v1.0.6 tag until this change. |
Thanks for this. I'm trying it in: #6409 |
What's the point of that bootstrap script? There's a good comment at the top on what the script does, but not the why. Does it "Verify the compiler can build itself, including test dependencies and any required Scala modules"? Is this to verify compatibility issues? |
An important part of the "why" is that in order to publish |
Oh, ok. The point is missing dependencies for milestone and new major Scala versions, thus the complete bootstrap. Thanks for the explanation. I'm very familiar with the Scaladoc dependency. |
the hope of course is to get scala-xml out of the 2.13 bootstrap, but
I'm not sure we'll get to it before M4. in the meantime, let's dogfood
the new release.