Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade scala-xml to 1.1.0 #6341

Merged
merged 1 commit into from Feb 24, 2018
Merged

Conversation

SethTisue
Copy link
Member

the hope of course is to get scala-xml out of the 2.13 bootstrap, but
I'm not sure we'll get to it before M4. in the meantime, let's dogfood
the new release.

the hope of course is to get scala-xml out of the 2.13 bootstrap, but
I'm not sure we'll get to it before M4. in the meantime, let's dogfood
the new release.
@scala-jenkins scala-jenkins added this to the 2.13.0-M4 milestone Feb 20, 2018
@SethTisue SethTisue merged commit fe6160c into scala:2.13.x Feb 24, 2018
@SethTisue SethTisue deleted the scala-xml-1.1.0 branch February 24, 2018 16:59
@retronym
Copy link
Member

This seems to break the boostrap build, at least the one used in the benchmarks.

For example, in build bootstrap-benchmark/637/, the build log shows the failure due to the addition of ScalaJS to the scala-xml build.

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-js#scalajs-library_2.13.0-pre-f993373;0.6.22: not found
[warn] 	:: org.scala-js#scalajs-test-interface_2.13.0-pre-f993373;0.6.22: not found
[warn] 	:: org.scala-js#scalajs-junit-test-runtime_2.13.0-pre-f993373;0.6.22: not found
[warn] 	:: org.scala-js#scalajs-compiler_2.13.0-pre-f993373;0.6.22: not found
[warn] 	:: org.scala-js#scalajs-junit-test-plugin_2.13.0-pre-f993373;0.6.22: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

@retronym
Copy link
Member

@sjrd I remember you experimenting with a way to easily enable/disable the ScalaJS SBT plugin. Did that turn into something we can use?

@sjrd
Copy link
Member

sjrd commented Mar 10, 2018

If you're talking about https://github.com/sjrd/sbt-dynscalajs, it works, yes. But please mind the readme about the expected level of support.

Anyway, I don't think your problem here is that it can't load the plugin. The resolution errors you see only happen if you actually try to compile the Scala.js part of the cross project. An easier and more stable fix would simply be to only compile (etc.) the JVM part of the cross projects inside scala-xml in the bootstrap build.

@ashawley
Copy link
Member

If you want to execute just the JVM targets in the scala-xml build, you can use the xmlJVM project in the scala-xml repo, so in this case you'd use xmlJVM/test and xmlJVM/publish and so on.

Why did this come up with upgrading the build to 1.1.0? The Scala.js changes have been in master for a year or so, now.

@retronym
Copy link
Member

Our bootstrap build was rebuilding the v1.0.6 tag until this change.

@retronym
Copy link
Member

retronym commented Mar 11, 2018

xmlJVM/test and xmlJVM/publish ...

Thanks for this. I'm trying it in: #6409

@ashawley
Copy link
Member

What's the point of that bootstrap script? There's a good comment at the top on what the script does, but not the why. Does it "Verify the compiler can build itself, including test dependencies and any required Scala modules"? Is this to verify compatibility issues?

@retronym
Copy link
Member

An important part of the "why" is that in order to publish scala-{library,reflect,compiler} to Maven Central, we need to create doc JARs. This requires scala-xml. If we're in a pre-release of Scala which doesn't make any binary compatibilty guarantees from one miletstone to the next, we can't necessarily use a published build of scala-xml. So we build it ourselves in the script.

@ashawley
Copy link
Member

Oh, ok. The point is missing dependencies for milestone and new major Scala versions, thus the complete bootstrap. Thanks for the explanation. I'm very familiar with the Scaladoc dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants