Avoid using STARR on the scalacheck classpath #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrating Scalacheck into our SBT build is all frying pans and fires. We disabled forking to get test failure reporting working, but didn't realise that this put STARR on the classpath of the tests. This commits switches back to forking, but only after customizing the framework to get early access to what hopefully will be part of the next scalacheck release: typelevel/scalacheck#388
retronym
commented
Mar 18, 2018
| if ((fork in Test).value) Nil | ||
| else List(Tests.Cleanup { loader => | ||
| ModuleUtilities.getObject("scala.TestCleanup", loader).asInstanceOf[Runnable].run() | ||
| }) |
There was a problem hiding this comment.
This only makes sense (and only works) in un-forked mode, but I opted to leave it around in case we switch back.
|
I'm going to merge this to unblock some downstream PRs. @SethTisue happy to rework based on post-hoc review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Scalacheck into our SBT build is all frying pans
and fires. We disabled forking to get test failure reporting
working, but didn't realise that this put STARR on the classpath
of the tests.
This commits switches back to forking, but only after customizing
the framework to get early access to what hopefully will be part
of the next scalacheck release: typelevel/scalacheck#388