New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2.12 to 2.13 mar 20 #6447
Conversation
lrytz
commented
Mar 20, 2018
`sbtResolve` is used in an `if` test. The last statement of the function makes the return value, so the `travis_fold_end` made it univerally `true`. For reference, the `errexit` mode (`set -e`, set in `common`) is ignored in the test position of an `if` statement (otherwise the build would have been aborted), see `man bash`.
Fix return value of sbtResolve
review by @szeiger |
Does this address the:
failures as seen since https://travis-ci.org/scala/scala/jobs/354791778 ? |
That's the goal! |
I tried running the old boostrap-benchmark job on 2.13.x (trying to get a build to run a benchmark), but ran into:
Not sure if that job is meant to work any more, so this is just FYI. |
Yeah, the pgp thing is a known issue, just haven't gotten around to fix it. The bootstrap job is supposed to work on jenkins too. |
I was impatient, benchmark is running now. |
yay! :-) |