Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid retaining refs to previously added items after VectorBuilder.clear #6779

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Avoid retaining refs to previously added items after VectorBuilder.clear #6779

merged 2 commits into from
Jun 14, 2018

Conversation

retronym
Copy link
Member

@scala-jenkins scala-jenkins added this to the 2.13.0-M5 milestone Jun 12, 2018
@retronym retronym requested a review from szeiger June 12, 2018 06:14
szeiger
szeiger approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@szeiger szeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a suitable solution since you discovered that we already avoid this kind of hidden structural sharing when slicing a Vector.

@adriaanm adriaanm merged commit e2e641e into scala:2.13.x Jun 14, 2018
@lrytz lrytz mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szeiger szeiger szeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0-M5
4 participants
@retronym @szeiger @adriaanm @scala-jenkins