Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OutOfMemoryError in mkString #6840

Merged
merged 1 commit into from Jun 28, 2018
Merged

Fix OutOfMemoryError in mkString #6840

merged 1 commit into from Jun 28, 2018

Conversation

mzuehlke
Copy link
Contributor

  • fix i/1 mix-up
  • add regression test

Fixes scala/bug#10951

@scala-jenkins scala-jenkins added this to the 2.13.0-M5 milestone Jun 21, 2018
@SethTisue
Copy link
Member

does the test really fail without the fix?

@mzuehlke
Copy link
Contributor Author

mzuehlke commented Jun 21, 2018 •
edited

Yes, it does. With the same OOM as given in the bug report.

@Ichoran
Copy link
Contributor

Ichoran commented Jun 21, 2018

LGTM

@SethTisue
Copy link
Member

SethTisue commented Jun 22, 2018 •
edited

pretty amazing there somehow wasn't test coverage for this already

@szeiger szeiger merged commit 53f06bc into scala:2.13.x Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szeiger szeiger szeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0-M5
5 participants
@mzuehlke @SethTisue @Ichoran @szeiger @scala-jenkins