Use MathContext in BigDecimal operations #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Jul 6, 2018
|
Thanks Greg. |
|
This is a breaking change that we should have release-noted. I added it to the 2.13.0 release notes just now. (People are still upgrading from 2.12.) There is further discussion on scala/bug#11590 and scala/bug#11152 (and if you keep chasing links, perhaps elsewhere as well). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a
BigDecimalcontains aMathContext, one would expect that to be used for all the operators where the Java API allows it. Currently that is not always the case. This adds theMathContextto all operations where it makes sense to use it, passing it along as an extra parameter to the Java method.I believe this makes sense because we are already doing it for
*and/, and it appears theMathContextwas omitted from the others for no particular reason.Fixes scala/bug#10882.