Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -Xfuture #7328

Merged
merged 2 commits into from Dec 4, 2018
Merged

Deprecate -Xfuture #7328

merged 2 commits into from Dec 4, 2018

Conversation

adriaanm
Copy link
Contributor

@adriaanm adriaanm commented Oct 10, 2018

Deprecates but doesn't remove the command-line option.

Close scala/scala-dev#471
Fix scala/bug#8361

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Oct 10, 2018
@@ -461,7 +458,7 @@ trait ScalaSettings extends AbsScalaSettings

/** Groups of Settings.
*/
val future = BooleanSetting("-Xfuture", "Turn on future language features.") enablingIfNotSetByUser futureSettings
val future = BooleanSetting("-Xfuture", "Deprecated. Does nothing.").withDeprecationMessage("Use -Xsource instead.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no future
In England's dreaming

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here to say "there is no future", but instead I am grateful for @eed3si9n . Note that maybe it's worse if the future "does nothing".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated message. It needn't be gloomy.

Remove the last reference to `settings.future`
Leave the now no-op command line option for now.
@som-snytt
Copy link
Contributor

compare #6974

@@ -1,4 +1,4 @@
// scalac: -Xfuture
// scalac: -Xsource:3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 2.14 instead of 3.0 ? We need to spread the pain a bit :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This represents a lot of pain, for not much gain (that I can see). Open to discuss, but my initial position is mild skepticism. I'm not yet convinced this should even be in 3.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's already deprecated no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not sure anymore deprecation is the right thing to do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I probably hold the minority opinion on this. The remaining discussion is to decide the version. We could do 2.14 if people think that's better.

Copy link
Member

@SethTisue SethTisue Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm surprised this is controversial at all, I would like to understand your (Adriaan's) thinking here. maybe we should discuss further in a more visible place? (scala/bug#8035, or Discourse?)

Copy link
Member

@xeno-by xeno-by Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to remove this in 2.14, I think we'll need to vote for that at a SIP meeting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since when is the committee concerned with the precise version number a deprecation happens in? It doesn't even get to specify the version in which a new feature will be implemented: https://docs.scala-lang.org/sips/sip-submission.html says

the committee asks the compiler maintainers to indicate the earliest version of Scala that can include the language change.

Note: asks the maintainers, it doesn't tell us. And we're also talking about the earliest version. Since deprecation is kind of the dual, we'd be asked about the latest version something should be deprecated. However, there isn't even a SIP process for deprecation -- that usually happens together with the new feature that replaces it. That particular feature will be discussed as part of the Scala 3 sip.

If you think the SIP committee mandate should be expanded to include require precise versions in which we should implement/remove things, please put that on the agenda for November. I'll say now that I'm not in favor.

@SethTisue SethTisue merged commit 238e5c2 into scala:2.13.x Dec 4, 2018
@SethTisue
Copy link
Member

the 2.14 vs 3.0 question can always be adjusted later

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Dec 4, 2018
@SethTisue SethTisue changed the title Drop last usage of -Xfuture Deprecate -Xfuture Apr 4, 2019
@shimamoto shimamoto mentioned this pull request Jul 25, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
7 participants