Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scala/bug#11010] Put back Coll for compatibility reasons #7380

Closed
wants to merge 5 commits into from

Conversation

grizio
Copy link

@grizio grizio commented Oct 31, 2018

The collection API was refactored.
The internal type Coll was removed in new factories.

To avoid breaking compatibility, we put it back in new factories for sub-types.

See scala/bug#11010

The collection API was refactored.
The internal type `Coll` was removed in new factories.

To avoid breaking compatibility, we put it back in new factories for sub-types.

See scala/bug#11010
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Oct 31, 2018
Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Small nit: I think it would be grammatically better to say "Use X directly" than "Use directly X"

src/library/scala/collection/Factory.scala Outdated Show resolved Hide resolved
src/library/scala/collection/Factory.scala Outdated Show resolved Hide resolved
src/library/scala/collection/Factory.scala Outdated Show resolved Hide resolved
src/library/scala/collection/Factory.scala Outdated Show resolved Hide resolved
@NthPortal NthPortal added the welcome hello new contributor! label Nov 1, 2018
NthPortal and others added 4 commits November 1, 2018 09:59
Co-Authored-By: grizio <gaetan@rizio.fr>
Co-Authored-By: grizio <gaetan@rizio.fr>
Co-Authored-By: grizio <gaetan@rizio.fr>
Co-Authored-By: grizio <gaetan@rizio.fr>
@grizio
Copy link
Author

grizio commented Nov 4, 2018

I just passed some hours but I did not find how to suppress the error:

covariant type CC occurs in invariant position in type CC[_] of type Coll

My knowledge on the matter is very limited. Except by impacting the rest of the collection, I do not see how to remove this error.

@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Nov 8, 2018
@grizio
Copy link
Author

grizio commented Nov 18, 2018

I tried again, but I do not find how to correct the compilation issue without impacting the design.
This PR gives no value so I am closing it.

@grizio grizio closed this Nov 18, 2018
@SethTisue
Copy link
Member

@NthPortal I haven't followed this... should this be revived in some form, or should we let it lie?

@SethTisue SethTisue removed this from the 2.13.0-RC1 milestone Nov 27, 2018
@SethTisue
Copy link
Member

actually let's discuss at scala/bug#11010 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library:collections PRs involving changes to the standard collection library welcome hello new contributor!
Projects
None yet
4 participants