Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #5104 and related NaN ordering inconsistencies #76

Merged
merged 1 commit into from
Dec 27, 2011
Merged

fixes #5104 and related NaN ordering inconsistencies #76

merged 1 commit into from
Dec 27, 2011

Commits on Dec 25, 2011

  1. fixes scala#5104 and related NaN ordering inconsistencies 

    The bug was caused by the inconsistency between j.l.Math.min() and
j.l.Double.compareTo() wrt NaN (j.l.Math.min() considers NaN to be
less than any other value while j.l.Double.compareTo() says it's
greater...)

The fix changes Ordering.{FloatOrdering,DoubleOrdering) to base
it's results on primitive comparisons and math.{min,max} instead
of j.l.{Float,Double}.compareTo()
    @khernyo
    khernyo committed Dec 25, 2011
    Configuration menu
    Copy the full SHA
    460bbc1 View commit details
    Browse the repository at this point in the history