Make unified collection serialization opt-in instead of opt-out #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any takers? This looks big but it's really just factoring out |
|
@SethTisue, could you look into this one? |
julienrf
reviewed
Jan 28, 2019
| } | ||
| new DefaultSerializationProxy(f, this) | ||
| } | ||
| } |
There was a problem hiding this comment.
If I understand correctly, developers who want to implement a custom collection type can mix this trait to support the proxy-based serialization?
class MyCollection[A]
extends Iterable[A]
with IterableOps[A, MyCollection, MyCollection[A]]
with DefaultSerializable { … }There was a problem hiding this comment.
Yes, that's what most of the collection classes are doing now (except from some wrapper classes like the Java/Scala converters which use the default serialization)
SethTisue
approved these changes
Jan 29, 2019
|
rebased |
adriaanm
added
the
library:collections
SethTisue
added a commit
to SethTisue/scala-xml
that referenced
this pull request
Feb 4, 2019
sjrd
added a commit
to sjrd/scala-js
that referenced
this pull request
Feb 7, 2019
Porting changes from scala/scala#7624.
This was referenced Mar 29, 2019
xerial
added a commit
to xerial/airframe
that referenced
this pull request
Mar 30, 2019
xerial
added a commit
to wvlet/airframe
that referenced
this pull request
Mar 30, 2019
…-RC1 failure (#479) * Add a workaround for classloader issues around sbt scala/scala#7624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11192