Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP a method with MethodType(Nil, _) may be a getter #7625

Closed
wants to merge 1 commit into from

Conversation

adriaanm
Copy link
Contributor

if it inherited the empty argument list from a java-defined method

Fix for scala/bug#11158

if it inherited the empty argument list from a java-defined method

11158
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Jan 10, 2019
@adriaanm
Copy link
Contributor Author

The real question is: should we stop faking the method type (vparamSymssOrEmptyParamsFromOverride) and fix overriding between java and scala arg-less methods in the overriding checks instead?

@adriaanm
Copy link
Contributor Author

I'm going to defer this post-2.13.0.

@lrytz
Copy link
Member

lrytz commented Mar 27, 2020

An alternative to this might be to drop the adapatation mentioned in scala/bug#11158 (comment). In the inverse case, overriding def f with def f(), we don't adapt either. See also #8293.

@SethTisue SethTisue marked this pull request as draft May 8, 2020 02:16
@SethTisue SethTisue removed the WIP label May 8, 2020
@SethTisue SethTisue modified the milestones: 2.13.3, 2.13.4 May 12, 2020
@adriaanm adriaanm closed this Oct 6, 2020
@SethTisue SethTisue removed this from the 2.13.4 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants