Future-proof the collections for Dotty #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
added
the
library:collections
smarter
force-pushed
the
dotty-library-2.13
branch
from
3b72bff
to
76a9c8c
Compare
Just like what we did for concat in scala#7696, we add a dummy parameter list to avoid signature clashes between mixin forwarders, but this change should be less controversial since it only affects a deprecated method. Note that this isn't actually needed to compile with Dotty master yet because we only emit mixin forwarders when required to, but we will soon switch to emitting them all the time like scalac does (scala/scala3#2563), therefore we need to get the fix in first (and most importantly in time for 2.13).
You know the drill: 8aa67d7
smarter
force-pushed
the
dotty-library-2.13
branch
from
76a9c8c
to
eba62a5
Compare
This does not appear to serve any purpose and it confuses Dotty.
julienrf
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like what we did for concat in
#7696, we add a dummy parameter list
to avoid signature clashes between mixin forwarders, but this change
should be less controversial since it only affects a deprecated method.
Note that this isn't actually needed to compile with Dotty master yet
because we only emit mixin forwarders when required to, but we will soon
switch to emitting them all the time like scalac
does (scala/scala3#2563), therefore we need
to get the fix in first (and most importantly in time for 2.13.0-RC1).