Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition options by function: -V verbose, -W warnings, preserving current aliases #7908

Merged
merged 3 commits into from
Mar 24, 2019

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Mar 22, 2019

Especially notable changes include:

  • -Werror is recommended over -Xfatal-warnings

Breaking changes include:

  • -Xprint:all is no longer accepted; use -Vprint:_
  • -warn-option is no longer accepted; use -Woption

This is a rebase of #7686

@eed3si9n eed3si9n added this to the 2.13.0-RC1 milestone Mar 22, 2019
Add standard option `-Werror` with `-Xfatal-warnings` alias.
As with javac, it appears on the `-help` output.

Rename `-Ywarn-foo-bar` as `-Wfoo-bar`, with the previous
name as a abbreviation or alias.

`-W` shows warnings, including all the `-Xlint` and `-Wunused`.

Use underscore to mean all phases

Move option note to bottom of message

-V for verbose nee debug options

Former flags future and experimental are more former.

Move output options to -V. Options which modify output
remain -Y. -Yprint-trees:text,compact,format,text+format
replaces -Yshow-trees-stringified, et al.

Reporter says -Werror

Briefer choices list

Briefer multichoices list

Tweak expressions

More -V
Also remove dependency on jackson for yaml output.
@adriaanm

This comment has been minimized.

@adriaanm

This comment has been minimized.

@adriaanm

This comment has been minimized.

@adriaanm adriaanm merged commit 97335fe into scala:2.13.x Mar 24, 2019
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 24, 2019
@eed3si9n eed3si9n deleted the wip/werror branch March 24, 2019 23:11
gslowikowski added a commit to scoverage/scalac-scoverage-plugin that referenced this pull request Apr 28, 2019
- upgrade Scala version from 2.13.0-M5 to 2.13.0-RC1 in `build.sbt` and `.travis.yml`

- upgrade scalatest version from 3.0.6-SNAP4 to 3.0.8-RC2
- upgrade stala-xml version from 1.1.1 to 1.2.0

Some fixes in tests were required:

- 's' and 'raw' string interpolators are now implemented as macros and macros are not instrumented; 's"Hello, $name"' expression was changed to explicit strings concatenation '"Hello, " + name' so the number of instrumented statements is the same in all Scala versions
see:
scala/scala@0cebcdf#diff-648e8f7f409d844c3c99b2d5a0d0dfe5R94
scala/scala#7779

- special symbol for all compilation phases was changed from "all" to "_"
see:
scala/scala@4d29431#diff-d686e8e67add4d42682f22193d20494bR1246
scala/scala#7908
@SethTisue
Copy link
Member

@som-snytt would you mind editing the PR title and description to indicate that more options are affected than just -warn-option? then I'll make a corresponding change in the 2.13.0 release notes

@som-snytt som-snytt changed the title Replace -warn-option with -Woption, rebased Partition options by function: -V verbose, -W warnings, preserving current aliases Jun 13, 2019
@SethTisue
Copy link
Member

I've added some bullets to the PR description with some specific changes I personally have found especially notable. We can add more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
4 participants