Eta lifts function before args. #7963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
requested changes
Apr 3, 2019
| 55 | ||
| F | ||
| Z | ||
| 55 |
There was a problem hiding this comment.
Is 55 some sort of senior citizens' joke?
|
Ach, good catch. I just read that bit, to be sure of myself, but I didn't read the examples, because who does that anymore? |
diesalbla
approved these changes
Apr 3, 2019
The comment says it, the spec says it, and most importantly, Dotty says it. Update the examples in the spec, which didn't say it. Maybe qualify for the coveted "performance" label by avoiding an argument load. Fixes scala/bug#11465.
som-snytt
approved these changes
Apr 6, 2019
|
@hrhino Is this ready? |
|
But for timing, should be. I'm in no rush, though. |
adriaanm
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment says it, the spec says it, and most importantly, Dotty says it.
Maybe qualify for the coveted "performance" label by avoiding an argument load.
Fixes scala/bug#11465.