A pair of thread safety fixes for runtime reflection. #8396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is worthwhile and low risk for 2.12.10, so setting that milestone. |
The stack trace in a customer's bug report suggests that
we need this to avoid races between these methods of
`TypeSymbol`.
```
private def setTyconCache(tycon: Type) {
tyconCache = tycon
tyconRunId = currentRunId
assert(tyconCache ne null, this)
}
```
```
override def info_=(tp: Type) {
tpePeriod = NoPeriod
tyconCache = null
super.info_=(tp)
}
```
Disable the cache of the `SubstMap` used in `Type.subst` when in the runtime reflection universe.
retronym
force-pushed
the
topic/reflection-thread-safety-tycon
branch
from
6f81450
to
67e4d95
Compare
adriaanm
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.