Make :javap in REPL work on JDK 11+
#8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
commented
Oct 21, 2019
src/repl-frontend/scala/tools/nsc/interpreter/shell/JavapClass.scala
Outdated
Show resolved
Hide resolved
som-snytt
force-pushed
the
issue/11154-2.13
branch
from
2881c5a
to
0de71b9
Compare
som-snytt
commented
Oct 21, 2019
|
|
||
| def compilerClasspath: Seq[URL] | ||
|
|
||
| def outputDir: AbstractFile |
There was a problem hiding this comment.
suboptimal for now, bytecode printing should be a service.
|
Requested retronym who requested a less budget-busting version. The LOC delta is a wash after refactor. I've already forgotten what it does. |
retronym
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Thanks for bravely straddling the JDK version chasm.
Later, we could consider making the code cleaner by making our build messier letting sub-projects be built with particular JDKs (or JDK.latest with particular -release arguments) and packaging the result up in a multi-release JAR. This could be useful in other spots of the library.
|
and another "Forward port javap support" ticket: lampepfl/dotty-feature-requests#80 |
Merged
SethTisue
changed the title
:javap in REPL work on JDK 11+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.