Restore warn-any improvement #8706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Feb 8, 2020
| if (!result && !seen(t)) t.dealiasWidenChain.foreach(saw) | ||
| } | ||
| } | ||
| @`inline` def containsAny(t: Type) = collector.collect(t) |
There was a problem hiding this comment.
The PR is green, with the same check files change as reverse(#8586), so LGTM.
There's a small change from reverse(#8586) (collector.collect(t) instead of t.dealiasWidenChain.exists(collector.collect)). But looking at the impl, it looks like it was a redudant dealiasWidenChain anyways.
It helps that the PR is green and the check files diff is the same. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the previous commit, which was withdrawn because of noise from the community build, which broke for a good reason.
See #8586 for context but please don't laugh.
The ticket was re-opened after the reversion.
Fixes scala/bug#11798