[forward port] Use Java semantics for imports in .java files #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An static member of a superclass may be referred to in an static import in Java sources qualified by a reference to the subclass. We've accounted for related problems previously in `typedIdent` and `typedSelect` by delegating to `javaFindMember`. This commit uses the same facility when checking that import selectors are valid and when checking if such an import contributes a name we are looking up. The test cases here use `-Ypickle-java` as a straightforward way to force typechecking all Java imports and signatures, however the bug fix is also beneficial outside of that mode if Scala code transitively depends on the correct interpretation of such a Java import. (cherry picked from ca7dc4d)
If we're typechecking a Java source file skip implicit gathering. It might have found some (from the imported Scala code, for instance) but they serve no purpose. I noticed this opportunity when I implemented Java semantics for static imports in the previous commit and looked at the callers of the changed code. I don't think we can add a similar fast path to Symbol.implicitMembers because a Java defined symbol might have Scala base classes that could contribute implicits to Scala code. (cherry picked from commit 398a891)
lrytz
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #8755 that was too conflicting to be part of the routine merge.