Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: JLine 3: fix handling of errors during tokenization #8880

Merged
merged 1 commit into from Apr 14, 2020
Merged

REPL: JLine 3: fix handling of errors during tokenization #8880

merged 1 commit into from Apr 14, 2020

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Apr 14, 2020 •
edited

high ratio of hours spent debugging to size of resulting fix, here

fixes scala/scala-dev#706

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 14, 2020
@SethTisue SethTisue mentioned this pull request Apr 14, 2020
Closed
@SethTisue SethTisue modified the milestones: 2.13.3, 2.13.2 Apr 14, 2020
@SethTisue SethTisue added the tool:REPL Changes in the Scala REPL Interpreter label Apr 14, 2020
dwijnand
dwijnand approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrytz lrytz merged commit a789d81 into scala:2.13.x Apr 14, 2020
@SethTisue SethTisue deleted the jline-tokenizer-errors branch April 14, 2020 13:34
@SethTisue SethTisue mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@som-snytt som-snytt Awaiting requested review from som-snytt

Assignees
No one assigned
Labels
tool:REPL Changes in the Scala REPL Interpreter
Projects
None yet
Milestone
2.13.2
4 participants
@SethTisue @dwijnand @lrytz @scala-jenkins