Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11997: Declare object cons before class Cons. #9035

Merged
merged 1 commit into from Jun 4, 2020
Merged

Fix #11997: Declare object cons before class Cons. #9035

merged 1 commit into from Jun 4, 2020

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jun 4, 2020

I can confirm that this fixes the build of Scala.js on Windows, which I locally tested.

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Jun 4, 2020
@sjrd sjrd modified the milestones: 2.13.4, 2.13.3 Jun 4, 2020
@sjrd
Copy link
Member Author

sjrd commented Jun 4, 2020

Thanks @dwijnand

I took the liberty to assign this to the 2.13.3 milestone. It should be very uncontroversial, and it's a major benefit for us, especially now that I have to work at home on Windows and that I have to work on supporting #8816

@dwijnand dwijnand merged commit 11b8ea5 into scala:2.13.x Jun 4, 2020
@dwijnand dwijnand mentioned this pull request Jun 4, 2020
Closed
@dwijnand dwijnand added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jun 4, 2020
@sjrd sjrd deleted the fix-stream-cons-override branch June 4, 2020 11:51
@kazchimo kazchimo mentioned this pull request Jun 17, 2020
Merged
joroKr21 added a commit to joroKr21/simulacrum that referenced this pull request Jun 18, 2020
@joroKr21
Fix Scala.js clash between Ops trait and ops object on Mac OS
3cd353e 
See scala/bug#11997 and scala/scala#9035
@joroKr21 joroKr21 mentioned this pull request Jun 18, 2020
Merged
joroKr21 added a commit to joroKr21/simulacrum-scalafix that referenced this pull request Jun 18, 2020
@joroKr21
Fix Scala.js clash between trait Ops and object ops on MacOS
132fdc9 
See scala/bug#11997 and scala/scala#9035
@joroKr21 joroKr21 mentioned this pull request Jun 18, 2020
Merged
travisbrown pushed a commit to typelevel/simulacrum-scalafix that referenced this pull request Jun 18, 2020
@joroKr21
Fix Scala.js clash between trait Ops and object ops on MacOS (#38)
7da9d39 
See scala/bug#11997 and scala/scala#9035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
2.13.3
3 participants
@sjrd @dwijnand @scala-jenkins