Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferred parens in junit tests #9048

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Preferred parens in junit tests #9048

merged 1 commit into from
Jun 10, 2020

Conversation

som-snytt
Copy link
Contributor

Reduce build noise.

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Jun 10, 2020
@som-snytt som-snytt added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jun 10, 2020
@som-snytt som-snytt requested a review from SethTisue June 10, 2020 02:53
@som-snytt
Copy link
Contributor Author

Or maybe increase build noise.

+Uncaught exception on thread Thread[Reflector-296,5,main]: java.lang.IndexOutOfBoundsException: -1 is out of bounds (min 0, max 1)
+java.lang.IndexOutOfBoundsException: -1 is out of bounds (min 0, max 1)
+	at scala.collection.mutable.ArrayBuffer.apply(ArrayBuffer.scala:96)
+	at scala.reflect.internal.tpe.TypeConstraints.containsSymbol(TypeConstraints.scala:205)
+	at scala.reflect.internal.tpe.TypeConstraints.solveOne$1(TypeConstraints.scala:256)
+	at scala.reflect.internal.tpe.TypeConstraints.$anonfun$solve$8(TypeConstraints.scala:290)
+	at scala.reflect.internal.tpe.TypeConstraints.solve(TypeConstraints.scala:290)
+	at scala.reflect.internal.tpe.TypeConstraints.solve$(TypeConstraints.scala:218)
+	at scala.reflect.internal.SymbolTable.solve(SymbolTable.scala:28)
+	at scala.reflect.internal.Types$ExistentialType.withTypeVars(Types.scala:3209)
+	at scala.reflect.internal.tpe.TypeComparers.thirdTry$1(TypeComparers.scala:553)
+	at scala.reflect.internal.tpe.TypeComparers.secondTry$1(TypeComparers.scala:520)
+	at scala.reflect.internal.tpe.TypeComparers.firstTry$1(TypeComparers.scala:496)
+	at scala.reflect.internal.tpe.TypeComparers.isSubType2(TypeComparers.scala:616)
+	at scala.reflect.internal.tpe.TypeComparers.isSubType1(TypeComparers.scala:348)
+	at scala.reflect.internal.tpe.TypeComparers.isSubType(TypeComparers.scala:306)
+	at scala.reflect.internal.tpe.TypeComparers.isSubType$(TypeComparers.scala:268)
+	at scala.reflect.internal.SymbolTable.isSubType(SymbolTable.scala:28)
+	at scala.reflect.internal.Types$Type.$less$colon$less(Types.scala:814)
+	at scala.reflect.internal.Types$Type.$less$colon$less(Types.scala:270)
+	at Test$.$anonfun$tasks$1(reflection-sync-subtypes.scala:7)
+	at Test$$anon$1.$anonfun$run$1(reflection-sync-subtypes.scala:15)
+	at Test$$anon$1.$anonfun$run$1$adapted(reflection-sync-subtypes.scala:15)
+	at Test$$anon$1.run(reflection-sync-subtypes.scala:15)

@som-snytt
Copy link
Contributor Author

/rebuild

@som-snytt
Copy link
Contributor Author

My bootstrap agrees with Travis.

dwijnand
dwijnand approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still draft?

@som-snytt som-snytt marked this pull request as ready for review June 10, 2020 07:44
@som-snytt som-snytt merged commit 1844d75 into scala:2.13.x Jun 10, 2020
@som-snytt som-snytt deleted the build/warnings branch June 10, 2020 07:45
@dwijnand dwijnand modified the milestones: 2.13.4, 2.13.3 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@SethTisue SethTisue Awaiting requested review from SethTisue

Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
2.13.3
3 participants
@som-snytt @dwijnand @scala-jenkins