RedBlackTree with fast mutable builder #9291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
merge/rbtree-builder
branch
2 times, most recently
from
bf61aec
to
2609de0
Compare
72 tasks
Cherry picked from e9d811e..e6e2e3d / scala#8794 The various approaches used to maintain serialization compatibility in 2.12.x can be dropped as they are obviated by use of serialization proxies in 2.13.x.
dwijnand
force-pushed
the
merge/rbtree-builder
branch
from
728f9f3
to
1fe3e24
Compare
diesalbla
added
the
library:collections
dwijnand
approved these changes
Nov 2, 2020
SethTisue
added
the
performance
|
There are a number of "Note - in 2.13 ..." comments in the diff were overlooked. Probably addressing them will fix scala/bug#12227. |
lrytz
reviewed
Nov 16, 2020
| // Note - in 2.13 this should be | ||
| // assertEquals(Map("a" -> "2"), r) | ||
| // as keys are retained | ||
| assertEquals(Map("A" -> "2"), r) |
There was a problem hiding this comment.
r is in fact ("a" -> "2"), but the test succeeds due to scala/bug#12228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this change forward individually rather than trying to do it as part of a routine 2.12->2.13 merge.
Cherry picked from e9d811e..e6e2e3d / #8794
The various approaches used to maintain serialization compatibility
in 2.12.x can be dropped as they are obviated by use of serialization
proxies in 2.13.x.
Closes scala/scala-dev#733