Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncomment an assert in compiler after re-STARR #9330

Merged
merged 1 commit into from
Nov 20, 2020
Merged

uncomment an assert in compiler after re-STARR #9330

merged 1 commit into from
Nov 20, 2020

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Nov 20, 2020 •
edited

happened across this. I don't know what it's about, but I guess someone else on the team might remember

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Nov 20, 2020
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Nov 20, 2020
@SethTisue SethTisue marked this pull request as draft November 20, 2020 02:03
@SethTisue
Copy link
Member Author

SethTisue commented Nov 20, 2020 •
edited

(need to land #9329 first, then rebase)

@lrytz
Copy link
Member

lrytz commented Nov 20, 2020

b79c0d124e and c0763b05da

@lrytz lrytz marked this pull request as ready for review November 20, 2020 07:53
@dwijnand dwijnand merged commit cc3242b into scala:2.13.x Nov 20, 2020
@SethTisue SethTisue deleted the uncomment-compiler-assert branch November 20, 2020 14:55
@som-snytt
Copy link
Contributor

Just happened across this while trying to understand mixins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
2.13.5
5 participants
@SethTisue @lrytz @som-snytt @dwijnand @scala-jenkins