New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbt 1.5 (was 1.4) #9444
Merged
Merged
sbt 1.5 (was 1.4) #9444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
the
internal
not resulting in user-visible changes (build changes, tests, internal cleanups)
label
Jan 21, 2021
dwijnand
approved these changes
Jan 21, 2021
CI likes it. closing for now, will reopen when there's another version. |
Thanks for checking! |
SethTisue
force-pushed
the
sbt-1.5
branch
2 times, most recently
from
March 15, 2021 15:50
e83c193
to
d041235
Compare
CI likes it. closing again until the next one |
CI likes it on 1.5.0-RC2, too 👍 |
(the change I just pushed was that Eugene's scalafix rules found a few places where |
I think I'd be comfortable with merging this. Anybody have doubts? |
dwijnand
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not for merge until 1.5.0 final, but let's make sure CI
likes it. cc @eed3si9n @adpi2