Fix and expand Array.apply optimization, part II #9461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension to the optimization in Cleanup of Array.apply assumed that the argument array was non-primitive. This broke compilation of spire (code minimized to test/files/run/sd760a.scala) I also found a path to the same bug without specialization, by using a generic type parmater bounded by a primitive. This is in test/files/run/sd760b.scala The fix here is straight forward -- disable this optimization when the argument array is primitive.
Avoid boxing the elements in favour of bulk clone of the varargs array into the result array, when the runtime type of the class-tag-generated result array is the same as the varargs array.
retronym
added
the
performance
retronym
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/scala-dev#760
Relates to #9356