REPL: when tab-completing, don't show a method as deprecated unless all overloads are deprecated #9510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbomrel2020
approved these changes
Feb 19, 2021
SethTisue
changed the title
SethTisue
changed the title
|
this isn't the behavior I expected: I had expected just: do you think the way you did it is better? |
I think |
|
@SethTisue Since Jline3 uses map when matching, only one key of the same group (default is ``) can be reserved. So it seems Scala itself can't fix the problem? Of course, we can try to put the one with description in front of the candidate list to get a candidate without description after covering, but I don't like this, what about you? |
This comment has been minimized.
This comment has been minimized.
jxnu-liguobin
force-pushed
the
fix-12338
branch
5 times, most recently
from
a306191
to
a8976a1
Compare
src/repl-frontend/scala/tools/nsc/interpreter/shell/ReplCompletion.scala
Outdated
Show resolved
Hide resolved
src/repl-frontend/scala/tools/nsc/interpreter/shell/ReplCompletion.scala
Outdated
Show resolved
Hide resolved
|
@jxnu-liguobin I like the behavior now. Can you squash this into a single commit? Then I think we can merge it. |
yes |
jxnu-liguobin
force-pushed
the
fix-12338
branch
3 times, most recently
from
712e8f2
to
eafe1cf
Compare
jxnu-liguobin
force-pushed
the
fix-12338
branch
from
eafe1cf
to
decec2e
Compare
|
@SethTisue Done, and I rolled back the modification to the minor problem because I couldn't reproduce it. If you find out, just point it to me. |
|
We can always adjust it again later if we notice something. |
|
Thank you! |
retronym
added a commit
to retronym/scala
that referenced
this pull request
May 20, 2021
Re-enable acronmyn-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. ``` REPL completion - Enable levenstien based typo matching scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 5, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 6, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jun 6, 2021
Re-enable acronym-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Under JLine completion, move all filtering up in the UI layer. Reimplement scala#9510 (dealing with overloads that contain some deprecated alternatives) in the UI layer Fix completion of keyword-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. Enable levenstien based typo matching, but disable it for short strings which IMO tends to offer confusing results. Enable levenstien based typo matching: ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein ```
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting candidates with description information in front and candidates without description information in the back, eventually only those without description will be displayed due to the de-duplication of Map Key.