Follow JDK 11+ spec for signature polymorphic methods #9530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No test case because JDK 11...
retronym
reviewed
Mar 3, 2021
| val resultType = | ||
| if (fun.symbol.tpe.resultType.typeSymbol != ObjectClass) fun.symbol.tpe.resultType | ||
| else if (isFullyDefined(pt)) pt | ||
| else ObjectTpe |
There was a problem hiding this comment.
Thanks for this, I'd just noticed a problem here yesterday!
Before:
scala> import java.lang.invoke._
import java.lang.invoke._
scala> class Data { var a: Int = 0; def aHandle = MethodHandles.lookup().findVarHandle(getClass, "a", classOf[Int])}
defined class Data
scala>
scala> val d = new Data
d: Data = Data@15c4b1a4
scala> d.aHandle.set(d, 2)
java.lang.NoSuchMethodError: VarHandle.set(Data,int)Object
at java.base/java.lang.invoke.MethodHandleNatives.newNoSuchMethodErrorOnVarHandle(MethodHandleNatives.java:589)
at java.base/java.lang.invoke.MethodHandleNatives.varHandleOperationLinkerMethod(MethodHandleNatives.java:542)
at java.base/java.lang.invoke.MethodHandleNatives.linkMethodImpl(MethodHandleNatives.java:475)
at java.base/java.lang.invoke.MethodHandleNatives.linkMethod(MethodHandleNatives.java:463)
... 28 elided
scala> d.aHandle.set(d, 2): Unit // workaround, fully define expected type as Unit
scala> d.a
res2: Int = 2
With your PR:
scala> d.aHandle.set(d, 2)
scala> d.a
val res9: Int = 2
retronym
approved these changes
Mar 3, 2021
|
Thanks, @lrytz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test case because JDK 11...
Fixes scala/bug#12348