-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partest tests can require a java version range #9587
Conversation
2ff6744
to
dee4b40
Compare
Ha, already looked at this when I woke up. Wondering if it means we can get rid of the "pragma" on the check file: control the version on the input side, not the output. |
I didn't add support for java version ranges to keep it simple, but that would also be a possibility. Getting rid of the pragmas in check files would then mean duplicating the test, which doesn't gain us much I think... |
There are only a few tests that are version or platform dependent. Maybe instead of range, just |
I agree that maintaining I can do version ranges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toolArgsForTheWin
595f3aa
to
5f8af99
Compare
Changed to support java version ranges, also added some doc to |
... using a `// javaVersion: N / N+ / N - M` comment in the test soruce. The test is skipped if the java version is outside the range.
5f8af99
to
3baff01
Compare
Thank you so much for adding this, and so promptly too. ❤️ |
... using a
// javaVersion: N / N+ / N - M
comment in the test soruce.The test is skipped if the java version is outside the range.